Something error about file write function

[winger]

Today I write a Script to download newlisp's benchmark code.

But I Can't find file in my directory.

I was scared! It been eat ! OMG

Code Select Expand


(set 'page (get-url "http://www.newlisp.org/benchmarks/"))
(set 'files (find-all {(syntax.cgi?benchmarks/.*newlisp.txt)"} page $1)) ;ye , this is error filename, so suk!
(println files)
(dolist (file files)
  (write-file (string "./"file)
  (get-url (string "http://www.newlisp.org/" file)))
  (println "->" file))

(exit)


[Lutz]

When you use syntax.cgi? in the URL you will get all the HTML too and ? is not allowed in file names. To get the raw text files:

Code Select Expand

(set 'page (get-url "http://www.newlisp.org/benchmarks/"))
(set 'files (find-all {(syntax.cgi?benchmarks/.*newlisp.txt)"} page $1))
(println files)
(dolist (file files)
  (set 'file (last (parse file "/")))
  (write-file file (get-url (string "http://www.newlisp.org/benchmarks/" file)))
  (println "->" file))

(exit)


[winger]

Yes .

You'are right.

In my opinion it should throw a waring message  when filename is incorrect.

Though we can use (true? filename) determine whether filename is correct.

[Lutz]

Like other file I/O functions in newLISP write-file will return nil on failure. You can then use sys-error to find out the error.



ps: this has been added to the reference manual.